I hope this message finds you well. I’m a bit unsure about the best practices for opening a pull request (PR) given that the DaisySP repository’s access is restricted.
My contributions involve a new module that I believe could be valuable to the DaisySP ecosystem.
It is GranularPlayer for the DaisySP. It’s designed to playback arrays of samples in both directions and offers independent control over time-stretching and pitch-shifting.
To give you a better idea, I am sending along a video that showcases a working example of my module in action. However, I want to make sure I follow the correct procedures and maintain a smooth and coordinated process with the DaisySP community.
I have a couple of questions that I would appreciate some guidance on:
Should I wait to open a PR for the module’s examples until the PR for the module itself is merged?
What is the process for contributing to the DaisySP repository, considering my contributions are local? Are there specific steps or guidelines I should follow? I have already read the contribution guidelines and style guide and made sure that the code follows it.
I understand that the DaisySP has some restrictions on access, and I want to make sure I respect these rules while actively participating in its development.
Your guidance and advice would be greatly appreciated, and I’m looking forward to your insights on the best practices for contributing to the DaisySP repository. Thank you for your time and support.
Thanks a lot for giving my implementation a try. Since it’s a PR still under review, you can follow these steps to address the issue and make use of the GranularPlayer module:
After completing all the steps outlined here, go ahead and delete the DaisySP folder from your DaisyExamples directory.
Clone the DaisySP version I’ve provided anywhere you prefer (cloning it in the root of the DaisyExamples folder would be easier). If you decide to clone the DaisySP folder elsewhere, make sure to copy it to the root folder of DaisyExamples. Note that this version is on the granular_player branch of my repository.
Execute the “rebuild_all” shell script found in the DaisyExamples repository.
You should be all set! If you encounter any further issues, feel free to reach out to me. I’ll do my best to respond promptly. Thanks!